multi-target and updated nuget packages

intercom / intercom-dotnet

Intercom API client library for .NET

https://developers.intercom.io/reference

Apache License 2.0

63 stars 54 forks source link

multi-target and updated nuget packages #147

Closed jpasichnyk closed 4 years ago

jpasichnyk commented 5 years ago

Why?

The current package isn't targeted against "net452" which many people are still using. This change to multi-target the library will allow many users currently stuck on the 1.0.x branch to use the latest version of the SDK.

How?

Added net452 as a second target framework in the .csproj files
Updated referenced NuGet packages

markalanevans commented 5 years ago

So if you are using 4.6.1 what happens?

lindeberg commented 5 years ago

Merge?

Bumbolio commented 5 years ago

Would love to see this merged and published to nuget as an official build. I have a large project running net452 and it would be great to use the latest build.

jonnyom commented 4 years ago

Hey folks, sorry for the delay on this.

We're good to merge this and we'll work on getting it published to Nuget ASAP

minhhieugma commented 4 years ago

why do you not have .net core library? it is terrible!!