intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 54 forks source link

Latest version 2.1.1 does not target .NET Standard #156

Open martinmasse opened 4 years ago

martinmasse commented 4 years ago

Hi,

It seems that we have lost the .NET Standard target in the latest release making it not compatible with .NET Core

mscrivo commented 4 years ago

yeah, this seems like a pretty bad regression.

hognevevle commented 4 years ago

Any ETA for a fixed package?

ThomasArdal commented 4 years ago

This is keeping me from updating as well.

gonace commented 4 years ago

Same here, would be great to get a "fix" for this 👍

johnnyoshika commented 4 years ago

Is this still an actively supported SDK?

AndiRudi commented 4 years ago

Hello we are also stuck in our migration for .net core. NETStandard is vital to move towards .net core.

AndiRudi commented 4 years ago

Someone made https://github.com/intercom/intercom-dotnet/pull/157 which should solve the issue

mngobbi commented 3 years ago

Maybe https://github.com/intercom/intercom-dotnet/pull/166 could help with this? Fixes that CircleCI build error too....

mgoodfellow commented 3 years ago

It looks like Intercom have completely dropped support for this library which is a real shame considering the cost of their product, and considering that the community have attempted to provide PRs to fix these issues but which are seemingly ignored. This project should be marked as deprecated.

A few options - fork it, and issue nugets from the patched PRs, or alternatively you can use 2.1.0 (https://github.com/intercom/intercom-dotnet/releases/tag/2.1.0) which does support netcore, but you will still be on the old v1.2 API (and who knows how long that will be supported for!) - https://github.com/intercom/intercom-dotnet/issues/163

Internally we have just setup a refit (https://github.com/reactiveui/refit) interface around some of their endpoints as needed, and define our own data models. Saves being bound to an unsupported and out of date library.

ThomasArdal commented 3 years ago

For future visitors and in addition to @mgoodfellow's comments, I'm using the 2.1.0 package with version 1.4 of Intercom's API. I haven't experienced anything that isn't working yet, but there could be something unsupported with that combination. Any newer versions of the API won't work with 2.1.0.

I can only agree with everything here. It's a shame that Intercom offers this package and then don't maintain it. Deprecate it or fix it.