search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

PCL friendly changes #38

Closed alexshikov closed 6 years ago

alexshikov commented 8 years ago

These changes are the first step for coming PCL migration PR.

It just fixes warnings, removes unnecessary usings and uses PCL-friendly API (see commit about Path.Combine)

khalilovcmd commented 8 years ago

Thank you for the PR and the effort @SeeD-Seifer , and I like where is this going 😉

choran commented 7 years ago

Hi @SeeD-Seifer Just wondering if you got a chance to get back to this or whether you were planning on making any other changes? We are reviewing some older PRs here and just wanted to check on the state of this. Thanks again Cathal

alexshikov commented 7 years ago

Hi @choran I didn't have a chance to continue a further investigation and, unfortunately, I don't have any plans anymore. Our project requires a complete UI feature set for Android and iOS so we have to look into native SDK + Xamarin bindings (when we'll have a time for this).

alexshikov commented 7 years ago

@choran I think you can close this PR as outdated.

kmossco commented 6 years ago

Closing this PR as mentioned by the OP. 👍 Thank you so much for taking the time to help us improve this library!