search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

fix (company): changed company.plan to string #65

Closed mickymcq closed 7 years ago

mickymcq commented 7 years ago

company.plan was a Plan object in this library. The API has it as a string value. Changed library to match API.

mickymcq commented 7 years ago

The API takes plan as a string, but when it returns the company info, it returns it as a Plan object. When going between the JSON and the Company object, this deals with the inconsistency.

choran commented 7 years ago

Hi @mickymcq This should be fixed now. We had an issue with the plan attribute that was addressed last week. It was set to a string but this was having issues deserialising the response. So we updated it to take an object which only sets the name and treat it as a sting when sending it to the API. That seems to have resolved the issues. I have since update the README now as well to show how to use it. Hope this helps resolve the issue. I will close this now since it should be resolved. Let me know if you are still having issues with this. Thanks again Cathal