intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

Company doesn't support website property #82

Closed juliancarrivick closed 6 years ago

juliancarrivick commented 7 years ago

As described in the API docs, there is a website property on a company, however as can be seen on Company.cs, this is not available on the C# model.

choran commented 7 years ago

Hi @juliancarrivick Yes, thanks for noting this, there were a few attributes recently added to the company model which we have not yet updated on all SDKs. We are trying to update all our SDKs for this but I cannot provide a timeline for this at present. If you would like to provide a PR for this we can review that also. We just note that this is an option for customers that can help with specific SDKs. If not np, like I said, we do aim to update this on all SDKs.

Cheers Cathal

juliancarrivick commented 7 years ago

Thanks Cathal, not a blocker for me so I'll try to do a pull request if I find time (I'll let you know if I start), otherwise it can wait until the update :)

kmossco commented 6 years ago

@juliancarrivick it seems that there are a few fields from the company model missing, and I was looking into adding them. However, if you're interested in doing this yourself I am more than happy to either review it or tag-team. 🙏

juliancarrivick commented 6 years ago

@kmossco Unfortunately I'm probably not going to get time to do this in the near future sorry :/

kmossco commented 6 years ago

@juliancarrivick no worries at all, thank you so much for flagging this! I'll get to it then. 😉

kmossco commented 6 years ago

Fixed by #86. Thank you so much for flagging this @juliancarrivick! 🤜 🤛