Company tag action does not currently support targeting by company_id

theandrewykim commented 6 years ago

Tagging a company with a company_id

Returns a 404. Currently the call is not sending any company data to Intercom on POST.

Labeling as a bug, as this behavior is currently documented.

tagsClient.Tag("new_tag", new List<Company>() { new Company() { id = INTERCOM_ID } });

tagsClient.Tag("new_tag", new List<String>() { INTERCOM_ID }, TagsClient.EntityType.Company);

Seem to work when specifically referencing the internal Intercom Id

thewheat commented 6 years ago

Digging into this, the code extracts just the id / Intercom ID value in several locations

Moving forward

Update Readme to make it clear that the ID is an Intercom ID (thus we should format the text to be similar to a regular Intercom ID)
Support tagging by company_id, email and user_id as it is supported in the docs

Users can be tagged by supplying a users array. The array contains objects identifying users by their id, email or user_id fields.

Companies can be tagged by sending a companies array. The array contains objects identifying companies by their id or company_id fields.

kmossco commented 6 years ago

Should be fixed by PR #91. Waiting on a review. 👍

intercom / intercom-dotnet

Company tag action does not currently support targeting by company_id #87