search

intercom / intercom-dotnet

Intercom API client library for .NET
https://developers.intercom.io/reference
Apache License 2.0
63 stars 53 forks source link

WHO does this #96

Closed ditchcode closed 6 years ago

ditchcode commented 6 years ago

I cannot believe after all this time the output library is still named Library.dll. What decent development team would make a decision to do this with the intention of releasing their API to the community?

kmossco commented 6 years ago

Hey @ditchcode! Completely understandable that it isn't the best of names, and it's actually something I hope to have fixed with a PR coming this week, so thank you for your feedback on this.

Note however that we are always happy to get Pull Requests from the community, so if you spot something that isn't quite right and have the time, feel free to send us a PR to review. We'd be happy to have more people contributing to this library. 👍

kmossco commented 6 years ago

I have now pushed a PR to fix this problem. Feel free to give it a shot and see if this fixes what you were referring to with the library output. I'll only close this when the PR is merged successfully. 👍

kmossco commented 6 years ago

This is now fixed in the new version. 🎉