search

intercom / intercom-go

Go Bindings For Intercom
https://developers.intercom.io/reference
Other
70 stars 78 forks source link

Update user companies to take a company rather than just a few fields. #12

Closed mackross closed 6 years ago

mackross commented 9 years ago

I found it annoying that I couldn't use the users api to create companies at the same time as a user with company_id.

josler commented 8 years ago

Hey @mackross, thanks for the PR!

The intent of using UserCompany rather than Company directly is to avoid being able to send fields that are not valid for updates through the API. We do a similar thing with User vs requestUser. It'd be great to instead update UserCompany to have the fields mentioned here: https://doc.intercom.io/api/#create-or-update-company and then generate one of those from the passed Company.

choran commented 6 years ago

Hi @mackross I was just following up on some older PRs that were still active. I was not sure if you had looked at this recently or had a chance to look at the suggested comment above? If you feel this is still active let me know Thanks Cathal

choran commented 6 years ago

Hi @mackross I am just going to close this now. Feel free to re-open if there is still an issue. Apologies for the delay here as well. We are working to respond to PRs much ore quickly in future. Thanks again Cathal