search

intercom / intercom-go

Go Bindings For Intercom
https://developers.intercom.io/reference
Other
70 stars 78 forks source link

Conversation does not include Tag List #76

Closed jskrepnek closed 6 years ago

jskrepnek commented 7 years ago

Version info

Expected behavior

Conversations.Find should return a struct of a Conversation containing a tag.list. The model returned from a method like Conversations.ListAll is slightly different in that it doesn't contain a tag.list, however the same struct is used for both methods. The API does return a tag.list when calling 'Get a single conversation'

Actual behavior

tag.list is not unmarshalled into the Conversation returned by Conversations.Find.

Thanks for your work on the SDK.

choran commented 6 years ago

Hi @jskrepnek Thanks for submitting the PR and sorry we have not got to it yet. We should be able to get to it this week. Cheers Cathal

choran commented 6 years ago

Just closing this since the PR was merged Thanks Cathal