search

intercom / intercom-go

Go Bindings For Intercom
https://developers.intercom.io/reference
Other
70 stars 78 forks source link

Setting avatar does not work (missing type) #80

Closed Scorpiion closed 6 years ago

Scorpiion commented 6 years ago

The Avatar object must have a type to be accepted by the API, this client does not have a type on the avatar object so it can't be set.

See Avatar object description here: https://developers.intercom.com/reference#section-avatar-object

See dotnet and java references here that has the type field:

I will make pull request for this now.

choran commented 6 years ago

Hi @Scorpiion Thanks for this, I was trying to test it but didnt manage to get it working. Were you able to add the avatar using your changes? If you were can you add a code example here in case I am testing it incorrectly ? Thanks again Cathal

Scorpiion commented 6 years ago

Hi @choran, sorry for not replying, been very busy.

No I have not tested it, not sure if there are any other issues but as you concluded in the pull request this change makes sense either way. I will try this later again when I have more time. Thanks for the help.