intercom / intercom-node

Node.js bindings for the Intercom API
https://developers.intercom.com
Other
366 stars 116 forks source link

Conversation create with subject #321

Closed song-huang closed 2 years ago

song-huang commented 2 years ago

Why?

Actually, we were always using from, body and subject parameters to create a new conversation, I don't find subject from your latest api document.

Although I don't know where and when my teammate found the subject parameter, but I can confirm that the parameter is available, and the the api also response with the subject field when request with subject. I also checked the conversation data from retrieve a conversation, the subject parameter actually is the title field.

How?

johnnynader commented 2 years ago

Hey @song-huang 👋 Thank you for your contribution. So our conversation api is meant for user messages which wouldn't have a subject. You should use our messages api for admin messages since it offers more fields and flexibility. Even though your implementation works, it's not intended behaviour and could be removed. Therefore I'm going to close this PR.

song-huang commented 2 years ago

Hi, @johnnynader, thanks for your explanations. I understand current issue of us, but I don't find parameter that can support our requirements via the messages api. The subject parameter seems only work from email type message and means the subject of email. The conversation title still is empty.