search

intercom / intercom-node

Node.js bindings for the Intercom API
https://developers.intercom.com
Other
366 stars 116 forks source link

Implement the list all subscripition types functionality #327

Closed lukasbals closed 1 year ago

lukasbals commented 2 years ago

Why?

Because I need this functionality in my application and I want to use the intercom-node SDK instead of accessing the API directly.

How?

I created subscriptions on the Client and a listTypes function to list all subscription types. I tried to be consistent with other parts of the client (e.g. segments)

lukasbals commented 2 years ago

@steve-henry or @johnnynader can you please take a look at this one? 🙂

lukasbals commented 2 years ago

@steve-henry and @johnnynader thanks for approving the test runs. As they succeeded, can I please have a review for the PR? 🙂

lukasbals commented 1 year ago

@steve-henry and/or @johnnynader can I please get a review on this one? 🙂