intercom / intercom-node

Node.js bindings for the Intercom API
https://developers.intercom.com
Other
366 stars 116 forks source link

Make CreateCompanyData fields optional #346

Closed sapkus closed 1 year ago

sapkus commented 1 year ago

Woudl be nice to have company fields optional, as it is in contact modal.

Current code:

interface CreateCompanyData {
    createdAt: Timestamp;
    companyId: string;
    name: string;
    monthlySpend: number;
    plan: string;
    size: number;
    website: string;
    industry: string;
    customAttributes: JavascriptObject;
}

Desired:

interface CreateCompanyData {
    createdAt?: Timestamp;
    companyId: string;
    name?: string;
    monthlySpend?: number;
    plan:? string;
    size?: number;
    website?: string;
    industry?: string;
    customAttributes?: JavascriptObject;
}
colmdoyle commented 1 year ago

Let me double check which of these are optional on the relevant endpoints, but assuming they're actually optional value (as I suspect they are), then yes, we can 100% make this change.

charsleysa commented 1 year ago

@colmdoyle has there been any update on this?

colmdoyle commented 1 year ago

Sorry, no!

We're not fundamentally opposed to it, just as with many things, we have competing priorities.

co-sic commented 1 year ago

@colmdoyle we would also like to see that change, any news?