search

intercom / intercom-rails

The easiest way to install Intercom in a Rails app.
https://developers.intercom.io/reference
MIT License
280 stars 106 forks source link

Restore Config.api_key= with deprecation warning #206

Closed eugeneius closed 8 years ago

eugeneius commented 8 years ago

https://github.com/intercom/intercom-rails/pull/205 removed the import rake task, along with the associated api_key configuration option. This means that users who have added an API key to their initializer will get this error when they update the gem:

NoMethodError:  method `api_key=' for IntercomRails::Config:Class

This brings back the method, but without any behaviour; it just prints a deprecation warning. This will allow those users to update to the latest version of the gem without causing an error when their app boots.

/cc @travega

kant01ne commented 8 years ago

:ship:

kant01ne commented 8 years ago

Thanks @eugeneius I just published the bug fix ;)

eugeneius commented 8 years ago

💪