Repair `user_id`-based Identity Verification, fixup 7e52538

intercom / intercom-wordpress

Intercom integration with Wordpress

28 stars 13 forks source link

Repair `user_id`-based Identity Verification, fixup 7e52538 #106

Closed lkraav closed 4 years ago

lkraav commented 5 years ago

This is a proper second pass to fix #74

I'd recommend releasing 2.6.2, because current version as is, anybody filtering in a user_id value will get broken Identity Verification.

lkraav commented 5 years ago

@apassant I highly recommend merging this to next release. As is, this plugin is breaking Identity Validation because my original patch was faulty, and apparently maybe the WP traffic to Intercom is just not high enough for anyone to really care.

lkraav commented 4 years ago

Rebased on top of latest master.

Y'all are still currently shipping a broken Identity Verification algorithm to whoever is using this plugin and we could fix it here. I've been running this in production for a year, it works correct. @SeanHealy33 @apassant ...anybody?

lkraav commented 4 years ago

Rebased on top of latest master.