interconnectapp / discuss

A place to discuss interconnect
https://github.com/interconnectapp/discuss/issues
Other
29 stars 6 forks source link

Channel buffering #19

Closed DamonOehlman closed 10 years ago

DamonOehlman commented 10 years ago

Hey Ben,

I'm not 100% sure if this is the problem or not, but I'm probably about 95% sure it is. There is currently a recommended max payload size of 16K (see Chrome 32 webrtc release notes - https://groups.google.com/forum/#!topic/discuss-webrtc/AefA5Pg_xIU) and I try to address that with the rtc-bufferedchannel module. It's still a work in progress but for the most part I think I've taken care of things there.

One thing I was noticing during my debugging though is that Firefox 26 seemed to not trigger the mySnapshotURIChanged polymer attribute change event (note the additional console log statement), but testing under Firefox 27 was completely different and it I got interop between FF 27 and Chrome 32 pretty much straight away. I'm not sure why this would be the case (I don't know enough about polymer), but I'm going to dig a bit further to make sure it's not rtc-videoproc or something else causing the problem.

Cheers, Damon.

balupton commented 10 years ago

Sweet. Will try it out now. Maybe this has something to do with Firefox 27 working: https://code.google.com/p/webrtc/issues/detail?id=2279#c11

DamonOehlman commented 10 years ago

Interesting - that might be right although Firefox 27 isn't playing nice for me now. Currently making sure the framelistener example in videoproc is working in FF.

balupton commented 10 years ago

So I merged in the changes, and it worked on I think the first try, but all tries after that. No luck. It seems calling between firefox and chrome also doesn't work currently.

I've pushed the latest to http://bevry.github.io/interconnect/

DamonOehlman commented 10 years ago

Just updated rtc-videoproc to 0.9.1 so if you update the script src to //wzrd.in/bundle/rtc-videoproc@~0.9.1 it should be all good (tested locally well here across a number of attempts).