interconnectedcloud / qdr-operator

Apache License 2.0
9 stars 15 forks source link

certmanager.k8s.io updated their CRD group to cert-manager.io #72

Open lenosi opened 4 years ago

lenosi commented 4 years ago

These URLs need to be updated.

https://github.com/interconnectedcloud/qdr-operator/blob/201e07eb8e6ffe97934d1848ab0d0ddb594ef903/test/e2e/framework/framework.go#L139 https://github.com/interconnectedcloud/qdr-operator/blob/201e07eb8e6ffe97934d1848ab0d0ddb594ef903/test/e2e/framework/framework.go#L325 https://github.com/interconnectedcloud/qdr-operator/blob/5cedbe8de9107bc0764c2b0a01b53cefbc9654f5/deploy/olm-catalog/qdr-operator/0.2.0/catalog-source.yaml#L232 https://github.com/interconnectedcloud/qdr-operator/blob/3984fddc8ad8092a67ffe84b778f8e09ef14749e/deploy/olm-catalog/qdr-operator/0.3.0/catalog-source.yaml#L232 https://github.com/interconnectedcloud/qdr-operator/blob/5cedbe8de9107bc0764c2b0a01b53cefbc9654f5/deploy/olm-catalog/qdr-operator/0.1.0/catalog-source.yaml#L232

grs commented 4 years ago

Ideally we would support both versions. I think @fgiorgetti did some initial investigation into that (it was not going to be trivial).

fgiorgetti commented 4 years ago

I have investigated that and also tried to add support for both versions in my fork: https://github.com/fgiorgetti/qdr-operator/tree/fg-certmanager-v0.11

The problem, if I still recall it, was that we tried to keep a backward compatible change, which did not work because of some internal references that are not using versioned packages, causing build to fail.

Not sure if current state of the upstream project allows mixing both. It needs some researches.