search

interconnectit / Search-Replace-DB

This script was made to aid the process of migrating PHP and MySQL based websites. Works with most common CMSes.
https://interconnectit.com/products/search-and-replace-for-wordpress-databases/
GNU General Public License v3.0
4k stars 855 forks source link

Updated README.md: It didn't seem to make sense, that index.php and wp-config.php would exist at a higher directory level than the rest of wordpress. #235

Closed rahvee closed 4 years ago

rahvee commented 6 years ago

Updated README.md: It didn't seem to make sense, that index.php and wp-config.php would exist at a higher directory level than the rest of wordpress.

kcristiano commented 6 years ago

@rahvee WordPress supports wp-config.php in a directory above the web root. If WP is installed in a subdirectory (as that example shows) there will be an index.php file there as well.

I understand it may not be intuitive, but it is detailed here: https://codex.wordpress.org/Giving_WordPress_Its_Own_Directory

A discussion that explains moving wp-config.php can be found here: https://wordpress.stackexchange.com/questions/58391/is-moving-wp-config-outside-the-web-root-really-beneficial

rahvee commented 6 years ago

Thank you for the reply. I have been a wordpress admin for something like 15 years, and I didn't know you could move wp-config.php up a level. Good to know. :-) The codex page specifically recommends against it, because it causes stability problems. There are conflicting opinions about it on the stackexchange page. In the end, the README.md file is yours, and it seems reasonable for you to keep it the way it is if you like it that way, but I still suggest taking the merge request because it's such an uncommon practice, and nobody expects such a practice to be advocated (without comment) in a README.md file on a search-replace script. The end result is probably just confusion that people just workaround by figuring out how to use the script and moving on with their day. So thanks for the reply... My opinion is you should still change the README.md... But it seems completely reasonable if you disagree with me. Anyway, thanks! :-)

kcristiano commented 6 years ago

@rahvee I am not a contributor, just a heavy user of this project. I actually find wp-config.php moved more often than I would expect. I do see the arguments against. The config detailed in the readme is not uncommon, but I do agree that it's not the most common.

I do think the most common example would be:


/website.com/index.php
/website.com/wp-config.php
/website.com/wp-settings.php
gianluigi-icit commented 4 years ago

WordPress can be configured in many ways, the readme is not a manual for it. Thanks rahvee for your pull request, but I'd like to keep the readme in that way.