search

interfasys / mediametadata

A cloud application which provides CRUD access to the metadata stored in images
GNU Affero General Public License v3.0
5 stars 1 forks source link

[First week] Create a version of the app which uses the old static hooks #13

Closed imjalpreet closed 8 years ago

imjalpreet commented 8 years ago

The related commit: f86c961

oparoz commented 8 years ago

I think you've linked the wrong commit. That commit is about trying to catche the events using the old hooks and is part of #15

imjalpreet commented 8 years ago

@oparoz Doesn't the old hooks method use the static hooks? I thought that way, and that's why I linked this commit. Also, I created #15 for the task of triggering the hooks for the sync client. Correct me if I have done some mistake.

oparoz commented 8 years ago

The old hooks methods use static hooks, yes, but this work all happened when we were trying to understand why the hooks didn't work via DAV events. I suggested you update your 2nd app which used those old hooks to see if it was a problem with the new hooks only. Does that sound correct?

imjalpreet commented 8 years ago

@oparoz, Yeah that's correct. But I think this commit doesn't include those changes, this commit just includes the basic skeleton of the old hooks. The DAV changes are included in this commit: 7f48f2c

Am I right?

oparoz commented 8 years ago

OK, I've reviewed the emails and the code. I had asked you to update the version of your trialApp so that we could test using both the old and the new hooks because the DAV changes from my PR were not triggering the expected events.

So yes, this is a separate sub-task of #15