search

interfasys / mediametadata

A cloud application which provides CRUD access to the metadata stored in images
GNU Affero General Public License v3.0
5 stars 1 forks source link

#5 Database Fields updated #23

Closed imjalpreet closed 8 years ago

imjalpreet commented 8 years ago

@oparoz I have updated the database.xml file. Please check if everything is correct. I have tested it.

oparoz commented 8 years ago

Just a heads up, in the first version, we'll go with priority 1 items only and once we have extractors and writers, we'll be able to quickly add priority 2 items.

imjalpreet commented 8 years ago

@oparoz I will update it then.

oparoz commented 8 years ago

I think the name of the index should be changed

imjalpreet commented 8 years ago

@oparoz Okay, I will change it. Do you have any suggestions? I mean are there any rules to be followed while naming it?

oparoz commented 8 years ago

There are a few conventions, but what bothers me in the current version is that image_size is not meaningful.

Something like idx_id per example would be pretty explicit: Index for for field id.

imjalpreet commented 8 years ago

Done.

oparoz commented 8 years ago

Thanks!

imjalpreet commented 8 years ago

@oparoz Do you want anymore changes in this?

oparoz commented 8 years ago

Could you just rebase it?

imjalpreet commented 8 years ago

@oparoz I rebased it.

oparoz commented 8 years ago

Thank you :)