Basic test setup - Githubissues

interfasys / mediametadata

A cloud application which provides CRUD access to the metadata stored in images

GNU Affero General Public License v3.0

5 stars 1 forks source link

Basic test setup #26

Closed imjalpreet closed 8 years ago

imjalpreet commented 8 years ago

@oparoz I have split #21 into two PRs. This PR does not contain the ImageHooksTest as requested by you.

oparoz commented 8 years ago

Coverage tests fail with PHP Fatal error: Uncaught Error: Class 'PHP_CodeCoverage'. Could you investigate why this is happening? Maybe a simple composer update will fix the problem. I saw that there was a new c3 component released recently.

imjalpreet commented 8 years ago

@oparoz Could you tell when did you get this error? I will try to test it on my machine.

oparoz commented 8 years ago

Sure, look at the report from Travis CI

oparoz commented 8 years ago

Since we need to get moving, here is what needs to be changed:

Use newer require-dev for your composer.json, you copied the one from an older version of Gallery: https://github.com/owncloud/gallery/blob/master/composer.json
Disable code-coverage for now and we'll enable it once we have tests running

imjalpreet commented 8 years ago

@oparoz Can you please check if changes are correct? I think I have disabled the code coverage for now and also updated the versions.

oparoz commented 8 years ago

If you look at the Travis report, you'll notice that you're not running the test: PHP7 + mysql, so just create a new line below the commented one with the same content except the extra coverage flags and we should be good to go.

imjalpreet commented 8 years ago

Done.

oparoz commented 8 years ago

Thanks!