Structure change - Githubissues

interfasys / mediametadata

A cloud application which provides CRUD access to the metadata stored in images

GNU Affero General Public License v3.0

5 stars 1 forks source link

Structure change #29

Closed imjalpreet closed 8 years ago

imjalpreet commented 8 years ago

@oparoz I have done the required changes and modified the structure of Image Hooks. Please have a look at it and give your suggestions.

Right now I have commented out the store part of EXIF and IPTC because that will only work when the PR of database.xml change is merged. Though, I have tested it and works.

imjalpreet commented 8 years ago

@oparoz I have added extract method for all the three metadata types but for store method to work #23 has to be merged.

oparoz commented 8 years ago

OK, I've added some comments in-line. Once those are fixed, you need to add the test for postCreate

imjalpreet commented 8 years ago

@oparoz I have used Dependency Injection. Please review it.

imjalpreet commented 8 years ago

@oparoz I am not able to figure out why Scrutinizer failed, can you check it once?

oparoz commented 8 years ago

Great, thanks. Now you can add the postCreate test, it should be easy this time.

imjalpreet commented 8 years ago

@oparoz Should I add the test in this PR only?

oparoz commented 8 years ago

Good point, let's keep changes small.

[x] Remove all non relevant code (EXIF, IPTC, etc.). Keep it handy for another PR
[ ] Merge this PR
[ ] Create postCreate test in another PR

And don't worry about Scrutinizer, it's a problem on their end.

imjalpreet commented 8 years ago

@oparoz I have removed the non relevant part as of now.

oparoz commented 8 years ago

Thank you, now you can create the postCreate PR.