search

interflop / interflop

Interflop ressources
GNU General Public License v3.0
4 stars 4 forks source link

Good practice to add our own frontend #1

Open dylan-brasseur opened 5 years ago

dylan-brasseur commented 5 years ago

Hi, I'm am working on the Interflop project with ANEO to develop a frontend for Interflop using DynamoRIO.

What would be a good practice to integrate this repository ?

Copying the backend and include folders doesn't seem ideal.

Thanks.

lathuili commented 5 years ago

Indeed it is not ideal. We need to discuss to define the good practice. With Verrou we copied all the backend in the verrou repository and today there are divergences. You can see that in the verrou repository we changed the interface to be able to chain backends. I think the new interface will be a good input for discussion.

pablooliveira commented 5 years ago

One possibility to add frontends is to include them as a git submodule. For instance, the verificarlo frontend is included inside the backend folder as a git submodule tracking the interflop branch.

If you need to add or change files in the include folder, you are encouraged to submit a PR.

@lathuili I think the current interface in interflop/interflop already allows chaining backends. At least, it is what we do in the verificarlo frontend. See this line for example for chaining all the loaded backends during a multiplication operation vfcwrapper.c#L143. By passing the result as a pointer, backends are free to take the result from a previous backend and alter it. Did I miss something ?

The changes I see currently in the verrou interflop interface are the addition of cast_double_to_float, madd_double and madd_float. I think those are good contributions and could be merged in interflop/interflop.

But yes, having a discussion in september to update the common interface would be great !