interglobalvision / estanciafemsa-mx

http://estanciafemsa.mx
Apache License 2.0
0 stars 0 forks source link

<em> italics not working #133

Closed mikeyrayvon closed 8 years ago

mikeyrayvon commented 8 years ago

on Home content title

mixcas commented 8 years ago

should i switch the field for a wysiwyg then?

mikeyrayvon commented 8 years ago

no its not that. its something weird with css

mixcas commented 8 years ago

in my local if i input <em>Somethong</em> the tags get stripped out

mikeyrayvon commented 8 years ago

it doesnt need tags. the em is in the markup

mikeyrayvon commented 8 years ago
screen shot 2016-09-12 at 7 51 27 pm

em is being overridden by our reset

mikeyrayvon commented 8 years ago

i usually set em and strong in /site.styl

mixcas commented 8 years ago

that's the reset. then to fix this we should add a class, i think its better than adding <em>.

mikeyrayvon commented 8 years ago

no because if someone sets italics in post content we want that to work

mixcas commented 8 years ago

then the issue is sitewide and not home content specific

mikeyrayvon commented 8 years ago

yes

mixcas commented 8 years ago

still tho. for elements that use italics as visual aid and not necessarily mean 'emphasis' i think its better to use a class and style that class than adding <em>

mikeyrayvon commented 8 years ago

but what about post content

mikeyrayvon commented 8 years ago

i see what you mean

mixcas commented 8 years ago

yes, in post content <em> should be used and work

in home content title a class should be used and styled to use italics

theres a semantic diff

mikeyrayvon commented 8 years ago

i said i see what you mean

mixcas commented 8 years ago

oh, i see it now :)