interlay / interbtc-clients

interBTC Clients | Vault, Oracle, Faucet
Apache License 2.0
52 stars 30 forks source link

Support Bitcoin core 25 #448

Open nud3l opened 1 year ago

nud3l commented 1 year ago

Is your feature request related to a problem? Please describe.

Vaults are currently using Bitcoin core 22. Bitcoin core 24 comes with support for more features and in the spirit of keeping dependencies up to date, we want to make sure we support the latest major release versions.

Describe the solution you'd like

Tests and add support for Bitcoin core 25. Make this the standard option for Vaults.

Additional context

Bitcoin core from version 23 comes with descriptor wallets by default.

sander2 commented 1 year ago

The main issue with bitcoin 23 was that it uses descriptor wallets by default

sander2 commented 1 year ago

The strategy will be to call createwallet with descriptor=false, for which I made the upstream pr: https://github.com/rust-bitcoin/rust-bitcoincore-rpc/pull/278

nud3l commented 1 year ago

Related, I think we should switch to using descriptor wallets: https://github.com/interlay/interbtc-clients/issues/457