interlay / interbtc-ui

Kintsugi and Interlay App - BTC DeFi
https://app.interlay.io/
Apache License 2.0
32 stars 30 forks source link

External price impact warning showing for 0.0% #1531

Open tomjeatt opened 1 year ago

tomjeatt commented 1 year ago

Is this right? Feel like we shouldn't be showing it for 0, but maybe an edge case:

Screenshot 2023-08-18 at 13 27 01
peterslany commented 1 year ago

I think the problem here is that ETH amount shows as 0 - probably the price is unavailable?

And I guess the calculation of price impact returns 0 in such case. So the question is how do we want to handle case when price of one of the assets is unavailable.