interlay / interbtc

interBTC: Bitcoin Anywhere
https://app.interlay.io/
Apache License 2.0
247 stars 83 forks source link

Use a single ID for lp token pair #945

Open gregdhill opened 1 year ago

gregdhill commented 1 year ago

Why is a stableLpToken identified by a single id whereas normal lptokens consist of a pair? That seems inconsistent to me. I realize that it's probably dictated by the zenlink pallet, I'm just wondering

_Originally posted by @sander2 in https://github.com/interlay/interbtc/pull/713#discussion_r1049681800_

gregdhill commented 1 year ago

Since we forked the Zenlink code it may be possible to use a PoolId to identify LP tokens in dex-general. This would negate the need to duplicate fields in the LpToken type.