Closed anton-karlovskiy closed 3 years ago
@nud3l I think this PR domonstrates how much code we can reduce by not using Redux. :)
Note that passing a query parameter that's not in the TAB_TYPES
object displays an empty modal. Maybe it's better to default to the issue
tab, also setting the parameter value
You probably didn't touch that code, but I'm getting two runtime errors just by browsing the app.
src/App.tsx
, where you need to import Big from 'big.js';
src/pages/dashboard/components/collateral-locked.tsx
, where fetchCollateralLastDays
has an unhandled Promise
rejectionThe "App" and "Dashboard" sections used to take a rather long time to load and now they're super snappy. This was done in many other PRs as well, but just wanted to say great work!
@savudani8 Re: https://github.com/interlay/polkabtc-ui/pull/210#issuecomment-822603816 It's done.
You probably didn't touch that code, but I'm getting two runtime errors just by browsing the app.
- One is in
src/App.tsx
, where you need toimport Big from 'big.js';
- The other is in
src/pages/dashboard/components/collateral-locked.tsx
, wherefetchCollateralLastDays
has an unhandledPromise
rejection
Could you please help them out by making changes to this PR? Or code suggestions, please.