search

interlay / polkabtc-ui

interBTC App - Mint 1:1 backed BTC on Polkadot and Kusama
https://bridge.interlay.io/
Apache License 2.0
12 stars 5 forks source link

Chanakya/add account name #222

Closed Chanakya888 closed 3 years ago

anton-karlovskiy commented 3 years ago

@Chanakya888 cc @nud3l Could you please let me know once you've finished? I'd like to have a look at the changes.

Chanakya888 commented 3 years ago

@Chanakya888 cc @nud3l Could you please let me know once you've finished? I'd like to have a look at the changes.

Yes Definitely

Chanakya888 commented 3 years ago

@nud3l @anton-karlovskiy Please have a look at the PR now.

  1. I've tested it to make sure it doesn't break the app if there's something wrong with name
  2. @nud3l I've added a green circle on the left to indicate that this account is currently selected and active, my thought is to have the vault and relayer text and icons (wherever applicable) right side of the text. Please let me know what you think about this choice
  3. I've also reduced the contrast as I felt pink is too much, reduced it down to reasonable grey
anton-karlovskiy commented 3 years ago

@Chanakya888 @nud3l FYI: let me have a look.

Chanakya888 commented 3 years ago

When you don't have the extension installed, it should show "Connect Wallet" on the account button on the right side button in the topbar, but it is empty:

image

Also, when you don't expose any of your accounts, the button should say "Select Account", but it is also empty:

image

I like the Green online thing and the more subtle grey selection :)

Whaat, that's weird. I am sure they were working when I tested, I am assuming they were lost during the refactor, @anton-karlovskiy please have a look.