search

interledger-deprecated / five-bells-ledger

Open-source reference ledger optimized for use with the Interledger protocol
Other
27 stars 21 forks source link

perf: Change default scale,precision to 10 digits before the comma, 9 after #400

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

if the currency is for instance dollars, precision will now be nanodollars, and maximum balance will be 10 billion dollars

justmoon commented 7 years ago

New scale fully includes the old scale, so it's technically not breaking anything, it may just be surprising to you that your ledger suddenly accepts higher precision transfers. I'd say minor version should be ok.

michielbdejong commented 7 years ago

Can't check what circleci is complaining about because circleci.com is down

codecov-io commented 7 years ago

Codecov Report

Merging #400 into master will not change coverage. The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   92.13%   92.13%           
=======================================
  Files          56       56           
  Lines        1805     1805           
  Branches      311      311           
=======================================
  Hits         1663     1663           
  Misses        142      142
Impacted Files Coverage Δ
src/lib/config.js 96.82% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 837dea5...e24de5e. Read the comment docs.