interledger-deprecated / five-bells-ledger

Open-source reference ledger optimized for use with the Interledger protocol
Other
27 stars 21 forks source link

Announce API version in ledgerUri endpoint #405

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

Currently, a lot of information about a FiveBells ledger can be obtained by looking at the ledgerUri, for instance: https://red.ilpdemo.org/ledger

In order for clients to know how to interact with a ledger, it would be helpful to also announce the API version, for instance "api_version": "five-bells@9". That way, pointing to a ledgerUri would be enough for for instance the https://connector.land diagnostics script to interact with the ledger. Currently I need to explicitly specify ledgerUri, ledgerType, and apiVersion, and ledger admins would have to do a pull request to connector.land each time they update their ledger. This currently affect connector.land script, but would also affect for instance third-party wallet clients that allow the user to connect to a ledger.

michielbdejong commented 7 years ago

Done in https://github.com/interledgerjs/five-bells-ledger/pull/410/files