search

interledger-deprecated / five-bells-ledger

Open-source reference ledger optimized for use with the Interledger protocol
Other
27 stars 21 forks source link

feat: checks max. once per minute if the DB is still alive #412

Closed dappelt closed 7 years ago

dappelt commented 7 years ago

It should not be possible to create a non-neglectable workload via unauthenticated endpoints such as /health. This commit limits the number of database queries that are trigger by requesting /health to 1 per minute.

codecov-io commented 7 years ago

Codecov Report

Merging #412 into master will increase coverage by 0.03%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #412      +/-   ##
==========================================
+ Coverage   92.13%   92.16%   +0.03%     
==========================================
  Files          56       56              
  Lines        1805     1812       +7     
  Branches      311      312       +1     
==========================================
+ Hits         1663     1670       +7     
  Misses        142      142
Impacted Files Coverage Δ
src/controllers/health.js 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 863c05d...66b6bc3. Read the comment docs.

emschwartz commented 7 years ago

This was replaced by https://github.com/interledgerjs/five-bells-ledger/pull/413, no?

dappelt commented 7 years ago

Closed in favor of #413