codecov-io
commented
6 years ago Codecov Report
Merging #434 into master will decrease coverage by
1.58%. The diff coverage is64.88%.
@@ Coverage Diff @@
## master #434 +/- ##
==========================================
- Coverage 90.91% 89.32% -1.59%
==========================================
Files 56 61 +5
Lines 1860 1911 +51
Branches 323 337 +14
==========================================
+ Hits 1691 1707 +16
- Misses 169 204 +35| Impacted Files | Coverage Δ | |
|---|---|---|
| src/models/db/fulfillments.js | 89.47% <100%> (ø) |
:arrow_up: |
| src/errors/unmet-condition-error.js | 100% <100%> (ø) |
|
| src/errors/missing-fulfillment-error.js | 100% <100%> (ø) |
:arrow_up: |
| src/errors/transfer-not-found-error.js | 100% <100%> (ø) |
:arrow_up: |
| src/errors/already-rolled-back-error.js | 100% <100%> (ø) |
|
| src/models/db/utils.js | 91.66% <100%> (ø) |
:arrow_up: |
| src/lib/rpcHandler.js | 95.29% <100%> (ø) |
:arrow_up: |
| src/errors/no-subscriptions-error.js | 100% <100%> (ø) |
:arrow_up: |
| src/controllers/transfers.js | 90.47% <100%> (ø) |
:arrow_up: |
| src/errors/transfer-not-conditional-error.js | 100% <100%> (ø) |
|
| ... and 16 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4b422ac...8e54637. Read the comment docs.
Requires interledgerjs/five-bells-shared#194
The goal here is to remove the dependence on five-bells-shared for error handling.
I'm hoping to eventually get rid of five-bells-shared and instead have small, reusable modules with fewer dependencies. Even better if we can use preexisting modules rather than creating our own.
This PR also gets rid of the Koa generator deprecation warning. (Because it switches the last remaining middlewares over to async/await.)