Open MatthewPhinney opened 8 years ago
According to Abraham, we should not be deleting rows in the db. Instead of deleting failed notifications, we should add a status column to the notifications table, and update the notification with status=failed. The relevant code is here: https://github.com/interledger/five-bells-shared/blob/81711eb3eb76f2f2d3425455baf448cc79ffa035/lib/notificationScheduler.js#L60.
status
status=failed
According to Abraham, we should not be deleting rows in the db. Instead of deleting failed notifications, we should add a
statuscolumn to the notifications table, and update the notification withstatus=failed. The relevant code is here: https://github.com/interledger/five-bells-shared/blob/81711eb3eb76f2f2d3425455baf448cc79ffa035/lib/notificationScheduler.js#L60.