search

interledger-deprecated / five-bells-shared

Common elements that are shared between Five Bells components
Other
4 stars 5 forks source link

fix: allow message.data as fallback #192

Closed sentientwaffle closed 7 years ago

sentientwaffle commented 7 years ago

See https://github.com/interledgerjs/ilp-plugin-bells/pull/142

codecov-io commented 7 years ago

Codecov Report

Merging #192 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #192   +/-   ##
=======================================
  Coverage   53.73%   53.73%           
=======================================
  Files          23       23           
  Lines         750      750           
  Branches      125      125           
=======================================
  Hits          403      403           
  Misses        347      347

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3670e9d...88d6ff8. Read the comment docs.

emschwartz commented 7 years ago

I'm on my phone so I can't click approve but LGTM

On Wed, Jul 12, 2017, 8:27 PM Codecov notifications@github.com wrote:

Codecov https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=h1 Report

Merging #192 https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=desc into master https://codecov.io/gh/interledgerjs/five-bells-shared/commit/3670e9d3b95ca78e3c7bcc161056c11fddc2a3ee?src=pr&el=desc will not change coverage. The diff coverage is n/a.

[image: Impacted file tree graph] https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=tree

@@ Coverage Diff @@## master #192 +/- ##

Coverage 53.73% 53.73%

Files 23 23 Lines 750 750 Branches 125 125

Hits 403 403 Misses 347 347

Continue to review full report at Codecov https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=continue .

Legend - Click here to learn more https://docs.codecov.io/docs/codecov-delta Δ = absolute (impact), ø = not affected, ? = missing data Powered by Codecov https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=footer. Last update 3670e9d...88d6ff8 https://codecov.io/gh/interledgerjs/five-bells-shared/pull/192?src=pr&el=lastupdated. Read the comment docs https://docs.codecov.io/docs/pull-request-comments .

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/interledgerjs/five-bells-shared/pull/192#issuecomment-314856332, or mute the thread https://github.com/notifications/unsubscribe-auth/ADHIkhZMtlij55EsNhq1jGV00zqNEzutks5sNRAWgaJpZM4OWBZy .

--

Evan Schwartz Software Engineer Managing Director of Ripple Luxembourg