search

interledger-deprecated / five-bells-shared

Common elements that are shared between Five Bells components
Other
4 stars 5 forks source link

fix: update vulnerable dependency #198

Closed dappelt closed 6 years ago

dappelt commented 6 years ago

marked@0.3.9 is added to devDependencies so that jsdoc is forced to use this version instead of an older vulnerable version of marked

dappelt commented 6 years ago

Integration tests are failing:

ilp-kit[Wallet2] Failed to compile.
ilp-kit[Wallet2] ./src/containers/App/App.js
ilp-kit[Wallet2] Module build failed: TypeError: Cannot read property 'type' of undefined
ilp-kit[Wallet2]     at Array.some (native)
ilp-kit[Wallet2]     at Array.forEach (native)

Investigating.

codecov-io commented 6 years ago

Codecov Report

Merging #198 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #198   +/-   ##
=======================================
  Coverage   57.98%   57.98%           
=======================================
  Files          19       19           
  Lines         676      676           
  Branches      113      113           
=======================================
  Hits          392      392           
  Misses        284      284

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ac89a74...b5a23b2. Read the comment docs.