Should we add event for when money is received?

interledger-deprecated / ilp-core

Core ILP module — handles ledger abstraction and quoting

Other

8 stars 5 forks source link

Should we add event for when money is received? #10

Closed emschwartz closed 8 years ago

emschwartz commented 8 years ago

Right now it seems like it would be easy to misunderstand the meaning of the receive event. It can either mean that you received money, in the case of an optimistic payment, or that you received a conditional transfer (and not money) that you need to submit the fulfillment for or wait for the fulfill_execution_condition event.

Should js-ilp or js-ilp-core have events that indicate whether money has actually been received? @justmoon

justmoon commented 8 years ago

Agree, I think that would go into ilp, since it's a feature related to the receiver use case. (The connector doesn't care whether it got paid or not, it will forward the payment either way.)