search

interledger-deprecated / ilp-core

Core ILP module — handles ledger abstraction and quoting
Other
8 stars 5 forks source link

feat: [BREAKING] update plugin options #31

Closed sharafian closed 8 years ago

sharafian commented 8 years ago

Addresses issue interledger/rfcs#55 . Instead of separating pluginOptions into auth and other options, the structure is flattened and special fields (such as store) are prefixed with an underscore. To work with ilp-plugin-bells and ilp-plugin-virtual it requires https://github.com/interledger/js-ilp-plugin-bells/pull/22 and https://github.com/interledger/js-ilp-plugin-virtual/pull/5, respectively.

emschwartz commented 8 years ago

LGTM

sentientwaffle commented 8 years ago

Shouldn't the README be updated as well?

codecov-io commented 8 years ago

Current coverage is 95.65% (diff: 100%)

Merging #31 into master will not change coverage

@@             master        #31   diff @@
==========================================
  Files             3          3          
  Lines           138        138          
  Methods          26         26          
  Messages          0          0          
  Branches         25         25          
==========================================
  Hits            132        132          
  Misses            6          6          
  Partials          0          0

Powered by Codecov. Last update 860e018...66c3b40

emschwartz commented 8 years ago

(@bensharaf I don't think this is a fix. It's not a bug, if anything it's kind of a small feature)

justmoon commented 8 years ago

LGTM