Proposal: Change `Core` to `ClientManager`

interledger-deprecated / ilp-core

Core ILP module — handles ledger abstraction and quoting

Other

8 stars 5 forks source link

Proposal: Change `Core` to `ClientManager` #56

Open sharafian opened 8 years ago

sharafian commented 8 years ago

The name Core isn't very descriptive of what the class does. Because it serves mostly the same purpose as Client but manages the same operations on a list of plugins, it would be easier for people to understand and use if it were called ClientManager or something similar.

emschwartz commented 8 years ago

I'm still confused about what the value add for Core/ClientManager is. Right now it seems like it's mostly a map of Clients indexed by their address. It seems like there's scope for this to do more though, especially regarding routing, retries, etc.