search

interledger-deprecated / ilp-core

Core ILP module — handles ledger abstraction and quoting
Other
8 stars 5 forks source link

feat: use localQuote if we have the curve #89

Closed michielbdejong closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #89 into master will decrease coverage by 17.88%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
- Coverage   97.44%   79.56%   -17.89%     
===========================================
  Files           3        3               
  Lines         235      230        -5     
  Branches       58       57        -1     
===========================================
- Hits          229      183       -46     
- Misses          6       47       +41
Impacted Files Coverage Δ
src/lib/core.js 52.22% <0%> (-45.68%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b77be2e...9428dd7. Read the comment docs.

sharafian commented 7 years ago

Can you test this branch on an ILP Connector using configured routes (CONNECTOR_ROUTES)? I suspect it breaks that functionality

michielbdejong commented 7 years ago

ilp-connector no longer uses ilp-core for quoting, it has its own quoter. So this PR is actually useless, probably.

michielbdejong commented 7 years ago

The commits from this PR live on in the mj-use-local-quote branch.