interledger-deprecated / ilp-kit

Everything needed to create a ledger and connect it to the Interledger
https://interledgerjs.github.io/ilp-kit/apidoc/
74 stars 39 forks source link

Deposit with Paypal does not show any errors #388

Open ghost opened 7 years ago

ghost commented 7 years ago

Just continuously shows loading indefinitely. Needs to at least show an error when one occurs. Replace with a throbber button and pop up 'This part may take a while, please be patient.'

ghost commented 7 years ago
screen shot 2017-05-09 at 6 48 23 pm

loading_indef

vhpoet commented 7 years ago

@peterjkrey do you have a correct paypal settlement method setup?

vhpoet commented 7 years ago

@peterjkrey did you check this?

ghost commented 7 years ago

Yes I have correct setup with sandbox mode secret and client ID. A deposit of a test $1 fails On Tue, Jun 6, 2017 at 8:04 AM Vahe Hovhannisyan notifications@github.com wrote:

@peterjkrey https://github.com/peterjkrey did you check this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/interledgerjs/ilp-kit/issues/388#issuecomment-306515031, or mute the thread https://github.com/notifications/unsubscribe-auth/AEVJzpGxNZJ6yQ4UxDJbX6EjoSFRJi1xks5sBWpegaJpZM4NWFZh .

--

Peter J Krey III

ghost commented 7 years ago

file_picture", "name", "phone", "address1", "address2", "city", "region", "country", "zip_code", "created_at", "updated_at", "invite_code" FROM "Users"
AS "User" WHERE "User"."username" = 'krey' LIMIT 1;
[ledger] 2017-06-06T18:44:41.036Z ledger:koa info <-- GET /accounts/krey
[ledger] 2017-06-06T18:44:41.043Z ledger:koa info --> GET /accounts/krey 200 7ms 192B
[api] 2017-06-06T18:44:41.043Z ledger INFO getting ledger info http://localhost:3101
[ledger] 2017-06-06T18:44:41.046Z ledger:koa info <-- GET /
[ledger] 2017-06-06T18:44:41.047Z ledger:koa info --> GET / 200 1ms 1013B
[api] 2017-06-06T18:44:41.049Z sequelize DEBUG Executing (default): SELECT "id", "type", "name", "logo", "description", "uri", "enabled", "options", "cr
eated_at", "updated_at" FROM "SettlementMethods" AS "SettlementMethod" WHERE "SettlementMethod"."enabled" = true AND "SettlementMethod"."name" IS NOT NU
LL;
[api] 2017-06-06T18:44:41.052Z http INFO   --> GET /config 200 38ms -
[api] 2017-06-06T18:44:41.095Z socket INFO Subscribe krey```

....

```[api] 2017-06-06T18:44:39.075Z sequelize DEBUG Executing (default): SELECT "id", "username", "email", "email_verified", "github_id", "destination", "pro
file_picture", "name", "phone", "address1", "address2", "city", "region", "country", "zip_code", "created_at", "updated_at", "invite_code" FROM "Users"
AS "User" WHERE "User"."destination" = '480511' LIMIT 1;
[api] 2017-06-06T18:44:40.114Z sequelize DEBUG Executing (default): SELECT "id", "type", "name", "logo", "description", "uri", "enabled", "options", "cr
eated_at", "updated_at" FROM "SettlementMethods" AS "SettlementMethod" WHERE "SettlementMethod"."type" = 'paypal' LIMIT 1;
[api] 2017-06-06T18:44:40.117Z connector:ledgers info adding ledger settlement.524c2981-2e00-4932-9ffa-f49a022e545b.
[api] settlements:174 { BigNumber Error: shift() argument not an integer: NaN
[api]     at raise (/home/pkrey/ilp-kit/node_modules/bignumber.js/bignumber.js:1198:25)
[api]     at intValidatorWithErrors (/home/pkrey/ilp-kit/node_modules/bignumber.js/bignumber.js:1108:17)
[api]     at BigNumber.P.shift (/home/pkrey/ilp-kit/node_modules/bignumber.js/bignumber.js:1954:20)
[api]     at FixerIoBackend.getCurve (/home/pkrey/ilp-kit/node_modules/ilp-connector/src/backends/fixerio/index.js:123:8)
[api]     at getCurve.next (<anonymous>)
[api]     at onFulfilled (/home/pkrey/ilp-kit/node_modules/co/index.js:65:19)
[api]     at /home/pkrey/ilp-kit/node_modules/co/index.js:54:5
[api]     at RouteBroadcaster.co (/home/pkrey/ilp-kit/node_modules/co/index.js:50:10)
[api]     at RouteBroadcaster.toPromise (/home/pkrey/ilp-kit/node_modules/co/index.js:118:63)
[api]     at next (/home/pkrey/ilp-kit/node_modules/co/index.js:99:29)
[api]     at onFulfilled (/home/pkrey/ilp-kit/node_modules/co/index.js:69:7)
[api]     at /home/pkrey/ilp-kit/node_modules/co/index.js:54:5
[api]     at RouteBroadcaster.co (/home/pkrey/ilp-kit/node_modules/co/index.js:50:10)
[api]     at RouteBroadcaster.createPromise (/home/pkrey/ilp-kit/node_modules/co/index.js:30:15)
[api]     at Promise.all.ledgers.getPairs.map (/home/pkrey/ilp-kit/node_modules/ilp-connector/src/lib/route-broadcaster.js:234:56)
[api]     at Array.map (native) name: 'BigNumber Error' }
[api] 2017-06-06T18:44:40.161Z http INFO   --> GET /settlements/480511/paypal/execute?paymentId=PAY-75X885785T570193PLE3PPWQ&token=EC-1YS91909TT919142R&
PayerID=W7GBVCKUUHRS2 302 1,120ms -
[api] 2017-06-06T18:44:40.346Z http INFO   <-- GET /auth/load```
ghost commented 7 years ago

paypal_deposit5 paypal_deposit3 paypal_deposit2 paypal_deposit1

vhpoet commented 7 years ago

@peterjkrey thanks for the screenshots. @sharafian here are some more details on the settlement plugin fail.

sharafian commented 7 years ago

Is this on the new version of the plugin?

vhpoet commented 7 years ago

@sharafian no

oniabifo commented 6 years ago

hey guys @sharafian @vhpoet, I am wondering if this issue has been resolved? If it hasn't, does any one knows the root cause of the issue? I am running into the same problem with paypal. Well, For me, i noticed when i click on Make a Payment, it displays

"69 | </div>}
70 |
71 | {destination.type === 'user' &&

72 | <div>You are depositing using <b>{params.method}</b>.</div>}
73 | </h3>
74 |
75 | <form onSubmit={this.handleSettle} className={cx('inputBox')}>"

before re-routing to paypal home page, then after clicking on continue, I get a settlement cancelled or failed error. Any helps/Tips on what might be wrong will be appreciated. Thanks.