interledger-deprecated / ilp-kit

Everything needed to create a ledger and connect it to the Interledger
https://interledgerjs.github.io/ilp-kit/apidoc/
74 stars 39 forks source link

Send 'hello' message to peer when user newly adds it #92

Open justmoon opened 7 years ago

justmoon commented 7 years ago

ILP Kit should keep track of current peers as well as adding/removing peers via the database, not via the configuration.

That will allow us to do things like managing peers via the UI (to make it more user-friendly for the operator) and even have an API for adding peers.

vhpoet commented 7 years ago

TODO

vhpoet commented 7 years ago

@sharafian is there a way to find out who has a one sided peering with you?

justmoon commented 7 years ago

@vhpoet: You'll receive RPC messages for a prefix you won't know what to do with...

@sharafian: We could make sure that the first RPC message that plugin-virtual sends is a handshake request with the information Vahe needs to detect it as a peering attempt.

@vhpoet: What information should an aspiring peer send? Name, logo, currency?

vhpoet commented 7 years ago

@justmoon host and currency for now.

justmoon commented 7 years ago

Let's also do limit.

vhpoet commented 7 years ago

@justmoon you mean a suggested limit ?

justmoon commented 7 years ago

No, I mean the hello packet should include the limit that the other side set, no?

justmoon commented 7 years ago

Talked to @vhpoet - the limit can already be queried and there is already code for querying it, so it makes no sense to include in the hello message.

michielbdejong commented 7 years ago

Peers are now stored in database, but we still need the 'hello' message.