search

interledger-deprecated / ilp-plugin-bells

ILP Ledger plugin for five-bells-ledger
Other
4 stars 8 forks source link

Compatibility section in the readme #116

Closed michielbdejong closed 7 years ago

michielbdejong commented 7 years ago

Referring to RFC versions by commit hash is a bit funny, but I guess it's good enough.

emschwartz commented 7 years ago

These commits should be squashed and should follow the commitizen format

codecov-io commented 7 years ago

Codecov Report

Merging #116 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
- Coverage   95.37%   95.34%   -0.03%     
==========================================
  Files          11       11              
  Lines         713      709       -4     
  Branches      172      171       -1     
==========================================
- Hits          680      676       -4     
  Misses         33       33
Impacted Files Coverage Δ
src/lib/plugin.js 96.79% <0%> (-0.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c4c86c...68dd5a8. Read the comment docs.

michielbdejong commented 7 years ago

Hah, using github's online editor interface let me bypass the commit hook :) Yeah, I was going to squash them, just hadn't done it yet.

@emschwartz done.

michielbdejong commented 7 years ago

Hm, tests failed with Error: Cannot find module 'five-bells-service-manager'

michielbdejong commented 7 years ago

Rebuilding circleci without cache