search

interledger-deprecated / ilp-plugin-bells

ILP Ledger plugin for five-bells-ledger
Other
4 stars 8 forks source link

feat: Adopt plugin interface proposed by gh:interledger/rfcs/pull/177 #118

Closed michielbdejong closed 7 years ago

codecov-io commented 7 years ago

Codecov Report

Merging #118 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #118   +/-   ##
=======================================
  Coverage   95.99%   95.99%           
=======================================
  Files          11       11           
  Lines         749      749           
  Branches      172      172           
=======================================
  Hits          719      719           
  Misses         30       30
Impacted Files Coverage Δ
src/lib/ledger-context.js 100% <ø> (ø) :arrow_up:
src/lib/translate.js 93.27% <100%> (ø) :arrow_up:
src/lib/plugin.js 97.96% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 803bd0d...57e5259. Read the comment docs.

sharafian commented 7 years ago

https://github.com/interledgerjs/ilp-plugin-bells/pull/118/files#diff-83847972f72b8fc383c14abb9f0791e1R417 is still using getInfo.scale

michielbdejong commented 7 years ago

rebased and squashed.

emschwartz commented 7 years ago

Commit was included in https://github.com/interledgerjs/ilp-plugin-bells/pull/120

michielbdejong commented 7 years ago

ah, thanks. sorry for leaving that dangling on friday.