search

interledger-deprecated / interledger

General information and docs about the Interledger project
11 stars 2 forks source link

Tutorial 2 feedback #1

Open emschwartz opened 7 years ago

emschwartz commented 7 years ago

npm install michielbdejong/ilp-node#62a7979

This command gets "no matches found" for me. Also, isn't it better to clone the repo? NPM Installing when you're not in a directory with a package.json file makes it end up a couple levels up

It would be good to make it print some more stuff about what I've actually started when I run that and what it's doing in the background.

flooder open, flooding

I like the idea of starting with you sending tons of payments, but I don't see it enough to really appreciate it. How do I know I really sent that many payments?

10000 transfers took 4179ms, that is 2392.916965781287 payments per second.

I'm not sure this is that impressive if it's all local. It might be more effective to send a single payment but print all the details of what happened.

The command in the first screen starts an Interledger connector.

Link to some description of a connector so I can read more about it if I want

who then sends 10,000 'PREPARE' messages to the connector.

What is a 'PREPARE' message?

The receiver fulfills its incoming transfers using the fulfillments which it shares with the sender in the script in the second screen.

What does it mean to fulfill incoming transfers? This either needs some explanation right here or a link to more of an explanation.

What's interesting is to compare one of the connector-to-receiver ("outgoing") transfers to the sender-to-connector ("incoming") transfer which it corresponds to

It might be interesting if I could actually compare them -- either with some debugging tools like BtpCat or even if you just included some samples in the Wiki page. It's fine to say these are binary protocols so you're going to show a pretty-printed JSON representation.

it will have the same executionCondition

This is the kind of thing that also needs more explanation or some links

Next

Add a link to the next one

michielbdejong commented 7 years ago

I guess we don't want to keep https://github.com/interledger/interledger/wiki/IToT-2-Interledger-over-BTP now that we have https://github.com/interledger/tutorials/pull/2