interledger-deprecated / java-crypto-conditions

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/crypto-conditions
Apache License 2.0
5 stars 12 forks source link

mvn install fails on tests #70

Closed diminator closed 7 years ago

diminator commented 7 years ago

I'm a really java noob, but trying the mvn clean install on master yields me some failed tests (and would not install)

Failed tests: 
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0008_test-basic-threshold [binary condition => uri] expected:<ni:///sha-256;tqz0CD5Di-Q1byX_ksKV6cjhurFBtGB7pIUR66Na78w?fpt=threshold-sha-256&cost=397315&subtypes=ed25519-sha-256,prefix-sha-256,rsa-sha-256> but was:<ni:///sha-256;tqz0CD5Di-Q1byX_ksKV6cjhurFBtGB7pIUR66Na78w?fpt=threshold-sha-256&cost=397315&subtypes=prefix-sha-256,rsa-sha-256,ed25519-sha-256>
  Test_ValidTestVectors.testParseFulfillmentAndValidate:214 0013_test-basic-rsa [fulfillment validate]
  Test_ValidTestVectors.testParseFulfillmentAndValidate:214 0003_test-minimal-rsa [fulfillment validate]
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0011_test-basic-threshold-two-levels-deep [binary condition => uri] expected:<ni:///sha-256;DJljCiAambB0jSutsgXlypOWksaH0cSml-ObqLoevnE?fpt=threshold-sha-256&cost=399366&subtypes=ed25519-sha-256,prefix-sha-256,preimage-sha-256,rsa-sha-256> but was:<ni:///sha-256;DJljCiAambB0jSutsgXlypOWksaH0cSml-ObqLoevnE?fpt=threshold-sha-256&cost=399366&subtypes=preimage-sha-256,prefix-sha-256,rsa-sha-256,ed25519-sha-256>
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0016_test-advanced-notarized-receipt [binary condition => uri] expected:<ni:///sha-256;CeORAEYocl6I-FV-lU-yoOrit8FRxH3zxK8i-MFpiPk?fpt=threshold-sha-256&cost=134304&subtypes=ed25519-sha-256,prefix-sha-256,preimage-sha-256> but was:<ni:///sha-256;CeORAEYocl6I-FV-lU-yoOrit8FRxH3zxK8i-MFpiPk?fpt=threshold-sha-256&cost=134304&subtypes=preimage-sha-256,prefix-sha-256,ed25519-sha-256>
  Test_ValidTestVectors.testParseFulfillmentAndValidate:214 0014_test-basic-rsa4096 [fulfillment validate]
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0017_test-advanced-notarized-receipt-multiple-notaries [binary condition => uri] expected:<ni:///sha-256;QkpwSUlSkme2IbPXkRnXKbI4LO2LKWw8Ao-pfTUPbQc?fpt=threshold-sha-256&cost=406738&subtypes=ed25519-sha-256,prefix-sha-256,preimage-sha-256> but was:<ni:///sha-256;QkpwSUlSkme2IbPXkRnXKbI4LO2LKWw8Ao-pfTUPbQc?fpt=threshold-sha-256&cost=406738&subtypes=preimage-sha-256,prefix-sha-256,ed25519-sha-256>
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0010_test-basic-threshold-same-fulfillment-twice [binary condition => uri] expected:<ni:///sha-256;jkM-9dPqoAorNKBcp8It05KXOhnxokMmjLUxEb3xyEQ?fpt=threshold-sha-256&cost=530438&subtypes=ed25519-sha-256,prefix-sha-256> but was:<ni:///sha-256;jkM-9dPqoAorNKBcp8It05KXOhnxokMmjLUxEb3xyEQ?fpt=threshold-sha-256&cost=530438&subtypes=prefix-sha-256,ed25519-sha-256>
  Test_ValidTestVectors.testParseConditionAndGenerateUri:118 0009_test-basic-threshold-same-condition-twice [binary condition => uri] expected:<ni:///sha-256;mgssY9-AaG5gINDKIcv-ZozOw9GvgnE_6um43UoPm7c?fpt=threshold-sha-256&cost=267264&subtypes=ed25519-sha-256,prefix-sha-256,preimage-sha-256,rsa-sha-256> but was:<ni:///sha-256;mgssY9-AaG5gINDKIcv-ZozOw9GvgnE_6um43UoPm7c?fpt=threshold-sha-256&cost=267264&subtypes=preimage-sha-256,prefix-sha-256,rsa-sha-256,ed25519-sha-256>
$ mvn --version
Apache Maven 3.3.9
Maven home: /usr/share/maven
Java version: 1.8.0_131, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.8.0-59-generic", arch: "amd64", family: "unix"
sappenin commented 7 years ago

Yes, that's been a silent issue for a while. In master, gradle is actually the preferred way to build the project (gradle build) but I have PR #68 that both fixes the unit tests (for real), transitions to maven, and also cleans-up the structure of the library a bit. Just waiting for some reviewers to take a look at it (ahem, @adrianhopebailie) and then hopefully we can push that soon-ish.

You might have better luck using the feature/immutable-crypto-conditions branch for now...

diminator commented 7 years ago
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
sappenin commented 7 years ago

Closing this issue since it's now fixed in the development branch.