Initial discussion-point commit of proposed InterledgerAddress per IL-RFC 15

[sappenin]

Starting-point PR to discuss a new InterledgerAddress...

• Updates InterledgerAdderss definition to conform to IL-RFC 15
• Transitioned to Interface so multiple implementations of InterledgerAddress can exist.
• Made InterledgerAddress immutable
• Made InterledgerAddress implementation disallows null per https://github.com/google/guava/wiki/UsingAndAvoidingNullExplained
• Added unit tests

[adrianhopebailie]

@sappenin this is great, thanks!

One question, shouldn't it replace the class at: https://github.com/interledger/java-ilp-core/blob/development/src/main/java/org/interledger/ilp/InterledgerAddress.java ?

[sappenin]

@adrianhopebailie Yes, it should. I'll updated the PR via d037add7dd05a4132159114aec75ad254d94ba66

[sappenin]

@adrianhopebailie In the previous version of InterledgerAddress, there is code relating to IA5 and translation from a byte[] into an InterledgerAddress. Does this need to be kept around? It's not clear to me why an InterledgerAddress would be created from a binary packet of data -- possibly from the binary data packet proposed in 168?

[sappenin]

I think the only remaining blocker for committing this PR was the discussion around whether or not to maintain the core package naming of org.interledger.ilp or use something else like org.interledger.core. After much discussion in the RFCs project (see the Converations tabs in RFC PR 181 and IL RFC Issue 180, I've come around to thinking of the thing in IL-RFC-3 as being called ILP.

Thus, I've moved the InterledgerAddress commits that are the main thrust of this PR back into the org.interledger.ilp package. So, I think this is ready to commit. If anyone else has changes or ideas or what-not, please create an issue and we can discuss more there.

[sappenin]

Successful Build here.

[adrianhopebailie]

Nice job!