search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

Added OER Support, restored from ancient java-crypto-condition version #20

Closed earizon closed 7 years ago

earizon commented 7 years ago

Restored (org.interledger.encoding.)OerInputStream and OerOutputStream

earizon commented 7 years ago

@sappenin

Any chance we could get unit tests for these? There is a new ILP binary packet being defined that might be a good candidate, but perhaps a more general set of tests is in order?

I just added a "draft" unit-test that writes OER to memory, then reads it backs. Far away from perfect, but still useful as documentation. Definetly testing with real ILP packet data is a "must".

https://github.com/interledger/java-ilp-core/pull/20/files#diff-287749664ce9c22151c7148d5b068c79

sappenin commented 7 years ago

LGTM! Can you merge this, or do I need to?

adrianhopebailie commented 7 years ago

@earizon, you should be able to merge. Let me know if not.

adrianhopebailie commented 7 years ago

@earizon the flow we are adopting is for committers to merge their own PRs once they have been reviewed and approved.

I've merged this one so it doesn't go stale

earizon commented 7 years ago

@adrianhopebailie (overflowed by a jungle of emails). Got it for next time!