search

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt
https://github.com/hyperledger/quilt/tree/master/ilp-core
Apache License 2.0
16 stars 10 forks source link

feat: implement PSK message (RFC 16) #26

Closed andrew-g-za closed 7 years ago

andrew-g-za commented 7 years ago

First stab at a PSK message implementation.

I'm not convinced the design is correct - opinions gratefully accepted. It also seems to rely heavily on byte[] - not sure if its worth moving to nio and ByteBuffer?

adrianhopebailie commented 7 years ago

Seems we might want to hold this PR until IL-RFC #197 is resolved (Should public headers be removed from PSK)?

Since we have no PSK functionality at all I'd suggest we merge and then adjust when IL-RFC #197 is resolved.

sappenin commented 7 years ago

Sounds good to me -- looks like a few test failures, but once that passes I'm good if this gets merged.

andrew-g-za commented 7 years ago

Cool, thanks for the feedback. My bad, I didn't spot the test-case failure the first time :( I'm pretty sure its related to the 256-bit key length, which requires the Java Cryptography Extension (JCE) Unlimited Strength Jurisdiction Policy Files. I'll try figure out how to get that into CircleCI

andrew-g-za commented 7 years ago

JCE policy now deploying in circleci, looks like the tests are passing. I see the previous commit for the OER encoding upset checkstyle, will fix in another submission.

sappenin commented 7 years ago

One other thought I had - what if we bump the version to 0.3.0-SNAPSHOT for this commit?

andrew-g-za commented 7 years ago

Yup, great idea. Let me get the OER fixes in underneath first, then we can use the PSK change to bump the release to v0.3 as you suggest (I wouldn't want to push this release as v0.3 then immediately have to commit small style changes into it).

See #27

sappenin commented 7 years ago

+1. Looks like #27 is good to go.