New ILP Payment & ASN.1 OER CoDec Design

interledger-deprecated / java-ilp-core

WE'VE MOVED: This project has moved to Hyperledger Quilt

https://github.com/hyperledger/quilt/tree/master/ilp-core

Apache License 2.0

16 stars 10 forks source link

New ILP Payment & ASN.1 OER CoDec Design #28

Closed sappenin closed 7 years ago

sappenin commented 7 years ago

Adds new models for InterledgerPayments and ILQP domain objects.
Introduces a new Encoder/Decoder (Codec) design to more easily map from various ILP encodings (e.g., ASN.1 OER, JSON, Protobuf, etc) to Java ILP Core model objects like an InterledgerPayment.
Merge-in PSK commits from @andrew-g-za (merged to dev on 5/8/17)
Re-structure the package naming scheme for better organization.
Unit test coverage.

sappenin commented 7 years ago

This PR is merely for review purposes of the new Codec features. I'll work on a separate PR to merge in Andrew's code for the PSK stuff in a separate PR.

adrianhopebailie commented 7 years ago

@sappenin - this looks great. I'd like to merge as soon as you have resolved conflicts with the PSK stuff from Andrew

sappenin commented 7 years ago

this looks great. I'd like to merge as soon as you have resolved conflicts with the PSK stuff from Andrew

Oops, I forgot to do a final merge from develop. That's pushed now, so we should be good to merge once I get at least 1 approval on the PR.

sappenin commented 7 years ago

I'm going to merge this now since it's so big, and work on @adrianhopebailie two remaining tasks in a separate PR.